Conversation
|
I'm not so sure if we should keep the old command. |
I say keep it for one release, users will see it's deprecated, remove in the release after. DRY is nice, but confusing users by disappearing commands instead of deprecating is also bad. |
4c31f8d to
94e6f0c
Compare
We translate to af internally, it's easier to store and doesn't break stored prefs. Made get/set af command show deprecated, but it still works fine.
94e6f0c to
f633843
Compare
Keep yes, very much. Soft transition is always best. |
|
We could call it an |
Co-authored-by: ViezeVingertjes <michael.overhorst@gmail.com>
acd1c9c to
1f48d2b
Compare
|
@liamcottle all comments addressed |
We translate to af internally, it's easier to store and doesn't break stored prefs. Made get/set af command show deprecated, but it still works fine.
Co-authored-by: ViezeVingertjes <michael.overhorst@gmail.com>
1f48d2b to
728b586
Compare
…o dutycycle-command
Allow users to simply set dutycycle percentage instead of having to deal with converting to airtime factor.
Old command still works but shows it's deprecated in favor of dutycycle command. We store internally all the same - this avoids breaking any prefs and works well enough internally.
Build it HERE