[Bug][SubscriptionBilling]: Customer cannot be changed on contract with closed subscription lines#7028
Open
miljance wants to merge 1 commit intomicrosoft:mainfrom
Open
[Bug][SubscriptionBilling]: Customer cannot be changed on contract with closed subscription lines#7028miljance wants to merge 1 commit intomicrosoft:mainfrom
miljance wants to merge 1 commit intomicrosoft:mainfrom
Conversation
github-actions
bot
added
AL: Apps (W1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request improves the handling of closed subscription lines in the service commitments logic and adds a new test to ensure correct behavior when changing the Sell-to Customer on contracts with closed lines. The key changes are grouped below:
Service Commitments Filtering:
table 8059 "Subscription Line"to filter out closed subscription lines by addingSetRange(Closed, false)in relevant methods, ensuring only open lines are considered in processing. [1] [2]Testing and Validation:
ChangeSellToCustomerOnContractWithClosedSubscriptionLinesincodeunit 148155 "Contracts Test"to verify that changing the Sell-to Customer on a contract with closed subscription lines does not result in errors, confirming the robustness of the new filtering logic.Work Item(s)
Fixes #6970