Fix reading relative path file reference#2119
Closed
dldl-cmd wants to merge 2 commits intomicrosoft:devfrom
Closed
Fix reading relative path file reference#2119dldl-cmd wants to merge 2 commits intomicrosoft:devfrom
dldl-cmd wants to merge 2 commits intomicrosoft:devfrom
Conversation
A reference like ./Directory/File.json#/components/schema/abc was before read as: refId = abc externalResource = ./Directory Which dropped the file name, which will be fixed by this commit
dldl-cmd
requested review from
MaggieKimani1,
andrueastman,
baywet,
darrelmiller,
gavinbarron,
irvinesunday and
millicentachieng
as code owners
baywet
requested changes
Feb 4, 2025
Member
baywet
left a comment
baywet
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
Can you please add unit tests so we don't get any future regression?
MaggieKimani1
approved these changes
Feb 6, 2025
Member
|
sorry for the closure, we changed the branching to align with other repositories. Can you also re-open the pull request to main please? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A reference like
./Directory/File.json#/components/schema/abcwas before read as:refId=abcexternalResource=./DirectoryWhich dropped the file name, which will be fixed by this commit
This fix will help the issue #1674 to get fixed.