refactor: replace rollup with tsc for browser package builds#778
Closed
layershifter wants to merge 1 commit intomicrosoft:mainfrom
Closed
refactor: replace rollup with tsc for browser package builds#778layershifter wants to merge 1 commit intomicrosoft:mainfrom
layershifter wants to merge 1 commit intomicrosoft:mainfrom
Conversation
📊 Bundle size reportUnchanged fixtures
|
…for builds Replace @nx/rollup:rollup executor with dual tsc builds (ESM + CJS) for the four browser packages. Uses composite project references to handle cross-package dependencies. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
5da2a63 to
bf2f769
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Note
Depends on #774
Summary
tsconfig.lib.cjs.jsonthat emits CJS todist/cjs/usingmodule: "node16"buildtargets in project.json run both ESM and CJS tsc builds@nx/rollup/pluginfrom nx.jsonTest plan
nx run-many -t type-checkpassesnx run-many -t buildpasses (both ESM and CJS output verified)nx run-many -t testpasses (including e2e-nextjs and e2e-rspack)nx run-many -t lintpasses🤖 Generated with Claude Code