refactor(postcss-syntax): switch from @griffel/babel-preset to @griffel/transform#810
Draft
layershifter wants to merge 6 commits intomicrosoft:mainfrom
Draft
refactor(postcss-syntax): switch from @griffel/babel-preset to @griffel/transform#810layershifter wants to merge 6 commits intomicrosoft:mainfrom
layershifter wants to merge 6 commits intomicrosoft:mainfrom
Conversation
…o @nx/js:tsc Replace @nx/vite:build with @nx/js:tsc executor for these three packages. This uses the TypeScript compiler directly instead of bundling via Rollup, producing individual output files matching the source structure. - Update project.json build targets to use @nx/js:tsc - Update package.json exports to use "default" condition (compatible with bundler resolution) - Add module: "ESNext" + moduleResolution: "bundler" to tsconfig.lib.json - Delete vite.config.ts (was build+test), create vitest.config.mts (test-only) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…_RSPACK branches Switch e2e-rspack from deprecated @griffel/webpack-extraction-plugin + @griffel/webpack-loader to the unified @griffel/webpack-plugin. Remove unnecessary IS_RSPACK conditionals in the plugin and loader now that Rspack supports NormalModule.getCompilationHooks and namedChunks.get(). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace all references to @griffel/webpack-loader and @griffel/webpack-extraction-plugin with the unified @griffel/webpack-plugin in the ahead-of-time compilation and CSS extraction docs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove the package and all references from tsconfig paths, copilot instructions, and website documentation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…-loader These packages are superseded by the unified @griffel/webpack-plugin. Updates all references in e2e tests, READMEs, tsconfig paths, and copilot instructions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…el/transform Eliminate the Babel dependency chain by having postcss-syntax consume @griffel/transform directly. This required extending transform's output with metadata (locations, comment directives) that the Babel location-preset previously provided. Transform changes: - Add SourceLocation, CommentDirective, TransformMetadata, ModuleConfig types - Accept ModuleConfig[] in modules option for flexible import matching - Collect call expression locations, slot locations, reset locations, and comment directives when generateMetadata is enabled - Return metadata in TransformResult postcss-syntax changes: - Remove @babel/core, @babel/helper-plugin-utils, @griffel/babel-preset deps - Add @griffel/transform dependency - Delete location-preset.ts (functionality now in transform) - Rename .ts → .mts, switch to ESM source - Switch from Jest to Vitest - Fix type-check cwd (was pointing to babel-preset) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@griffel/transformwith metadata output (locations, comment directives) thatpostcss-syntaxneeds, eliminating the need for@griffel/babel-presetand its Babel dependency chain@griffel/postcss-syntaxto consume@griffel/transformdirectly — removes@babel/core,@babel/helper-plugin-utils,@griffel/babel-presetdependencies.tsto.mtssource filesTest plan
npx nx run-many -t build -p transform postcss-syntaxpassesnpx nx run-many -t test -p transform postcss-syntaxpasses (95 tests: 73 transform + 22 postcss-syntax)npx nx run-many -t type-check -p transform postcss-syntaxpasses🤖 Generated with Claude Code