Conversation
kanchansenlaskar
left a comment
kanchansenlaskar
left a comment
There was a problem hiding this comment.
@copilot list out all the test cases which are getting impacted and are worth testing for this change
|
@kanchansenlaskar I've opened a new pull request, #4362, to work on those changes. Once the pull request is ready, I'll request review from you. |
There was a problem hiding this comment.
Pull request overview
This PR updates Azure platform capability-selection error reporting so skipped tests can surface requirement-mismatch reasons (instead of a generic skip/quota message) when no candidate VM sizes satisfy the test requirements.
Changes:
- Persist unmet requirement reasons during
_get_meet_capabilitiesevaluation so they can be reused later for skip messaging. - Build a de-duplicated “Requirement mismatch” error string from collected reasons when VM selection fails.
- Replace the prior generic “no available quota found” message with a more detailed (or fallback) skip reason.
You can also share your feedback on Copilot code review. Take the survey.
| else: | ||
| # Collect unique reasons from the first failing candidate to | ||
| # surface a meaningful skip message instead of a generic one. | ||
| if not unmet_reasons: | ||
| unmet_reasons.extend(check_result.reasons) |
| error = ( | ||
| f"Test skipped on '{location}' for an unknown reason. " | ||
| "This could be due to insufficient quota, unmet hardware " | ||
| "requirements, or other undiagnosed causes. " | ||
| "Manual investigation may be required." |
kanchansenlaskar
left a comment
kanchansenlaskar
left a comment
There was a problem hiding this comment.
@copilot list out all the test cases which are getting impacted and are worth testing for this change
|
@kanchansenlaskar I've opened a new pull request, #4363, to work on those changes. Once the pull request is ready, I'll request review from you. |
Description
Related Issue
Type of Change
Checklist
Test Validation
Key Test Cases:
Impacted LISA Features:
Tested Azure Marketplace Images:
Test Results