Fix code quality issues in SqlDecimal migration#81
Closed
Copilot wants to merge 4 commits intodev/monamaki/useSqlDecimalfrom
Closed
Fix code quality issues in SqlDecimal migration#81Copilot wants to merge 4 commits intodev/monamaki/useSqlDecimalfrom
Copilot wants to merge 4 commits intodev/monamaki/useSqlDecimalfrom
Conversation
Co-authored-by: monamaki <77026206+monamaki@users.noreply.github.com>
Co-authored-by: monamaki <77026206+monamaki@users.noreply.github.com>
Co-authored-by: monamaki <77026206+monamaki@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update SQL handling for decimal values
Fix code quality issues in SqlDecimal migration
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses code quality issues found during review of the
decimal→SqlDecimalmigration for full 38-digit SQL Server NUMERIC/DECIMAL precision support.Changes
Fix broken indentation in
ExtractNumericColumn— Theif/elsepattern had theelseblock body at the wrong nesting level. Restored early-return guard clause, which is both correct and consistent with the rest of the codebase.Replace magic number with named constant —
*strLenOrNullMap = 19→*strLenOrNullMap = SqlNumericStructSizeinCSharpParamContainer.cs. The constant already exists inSql.csand is used elsewhere for the same purpose.Remove unused import and stray blank line in
SqlNumericHelper.cs(System.Linqwas never referenced).Before/After (
ExtractNumericColumn)✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.