Fix instability issue in e2e testing#10106
Open
zedy-wj wants to merge 2 commits intomicrosoft:mainfrom
Open
Conversation
zedy-wj
requested review from
AlitzelMendez,
RodgeFu,
bterlson,
chrisradek,
lirenhe,
markcowl,
timotheeguerin and
witemple-msft
as code owners
microsoft-github-policy-service
bot
added
the
ide
commit: |
Contributor
|
No changes needing a change description found. |
Collaborator
|
You can try these changes here
|
Member
There was a problem hiding this comment.
I don't think this will solve both issue if they are not the same thing underneth. The 2nd one crash before any of the code changes are
packages/typespec-vscode test:e2e: FAIL create-typespec.test.ts > CreateTypespecProject > CreateTypespecProject GenericRestAPI Trigger CommandPalette EmptyFolder
packages/typespec-vscode test:e2e: Error: electronApplication.firstWindow: Target page, context or browser has been closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #9938.
Some optimization steps have been added to handle instability errors.
@timotheeguerin for notification.