Feature/ledger signer #1944

OBorce · 2025-07-30T13:35:25Z

Ledger signer
Ledger tests

Tests assume the ledger app is already running in the emulator same as Trezor tests

ImplOfAnImpl

I haven't dug into the code much yet, will continue next week.

Tests assume the ledger app repo is cloned next to this one with name ledger-mintlayer

To be honest, I'm not a huge fan of this approach. And also of the fact that the emulator is always started automatically. E.g. in the Trezor case it was sometimes useful to see the emulator logs to understand what went wrong.
Was there any particular reason to do it this way instead of expecting the emuator to be running?

wallet/src/signer/ledger_signer/speculus/drivers/mod.rs

wallet/src/signer/ledger_signer/speculus/handle.rs

Cargo.toml

wallet/src/signer/ledger_signer/speculus/mod.rs

wallet/src/signer/ledger_signer/speculos/handle.rs

wallet/src/signer/ledger_signer/speculos/drivers/mod.rs

wallet/src/signer/ledger_signer/ledger_messages.rs

Cargo.toml

wallet/src/signer/ledger_signer/ledger_messages.rs

ImplOfAnImpl · 2025-10-08T12:25:48Z

wallet/src/signer/ledger_signer/ledger_messages.rs

+pub async fn get_app_name<L: Exchange>(ledger: &mut L) -> Result<Vec<u8>, ledger_lib::Error> {
+    let msg_buf = [CLA, Ins::APP_NAME, 0, P2::DONE];
+    ledger.exchange(&msg_buf, Duration::from_millis(100)).await
+}
+
+#[allow(dead_code)]
+pub async fn check_current_app<L: Exchange>(ledger: &mut L) -> SignerResult<()> {
+    let resp = get_app_name(ledger)
+        .await
+        .map_err(|err| LedgerError::DeviceError(err.to_string()))?;


I don't think it's a good way to check for our app, because the INS values are app-specific.

There is a standard way to obtain the app name via CLA=0xB0 and INS=1. E.g. here it's handled by the SDK on the device - https://github.com/LedgerHQ/ledger-device-rust-sdk/blob/4262899a325b9b2fe10f2524d8e4b2f9fec38b83/ledger_device_sdk/src/io_legacy.rs#L330-L331
(The INS is processed inside the handle_bolos_apdu function).

Also, ledger-proto contains something called AppInfoReq which mentions CLA 0xB0 and INS 1, so I guess you don't have to construct the APDU by hand and parse the request.

For some reason it always returns "app" for app name and the OS version instead of the opened app. So, I kept our own instructions.

For some reason it always returns "app" for app name and the OS version instead of the opened app. So, I kept our own instructions.

Well, I tried sending [b0, 1, 0, 0] to my NanoSPlus and got "Mintlayer"/"0.1.0" for our app and "Ethereum"/"1.18.0" for Ethereum.
What device are you using? Can you double check?

In any case, this has to be investigated further. If b0/01 doesn't work indeed, we must at least document that fact, mentioning the particular situations.

For some reason it always returns "app"

So I suppose you were using the emulator, for which this is documented behavior.

In such a case IMO it's better to detect if we're using an emulator (or I guess we could assume that any tcp transport corresponds to an emulator) and skip the app name/version check in that case.

Alternatively, we could go with with a custom APDU. But in this case it has to be handled more carefully. E.g. a) expect that the whole APDU may fail, e.g. with ClaNotSupported or InsNotSupported (because the current app doesn't support it), or with something like WrongP1P2/WrongApduLength (because in the current app this APDU means something else and has different parameters); b) expect that APDU may be handled successfully, but the result is garbage (again, because in the current app this APDU means something else).

The first approach looks easier to implement.

wallet/src/signer/ledger_signer/mod.rs

wallet/src/signer/ledger_signer/tests.rs

ImplOfAnImpl

I don't want to review this again, so I suggest merging it after applying the comments. The ledger tests will have to be disabled on CI, but it's better to enable the code itself, to make sure it compiles.

Plz make sure that all the comments have been addressed before merging

ImplOfAnImpl · 2026-01-15T21:08:29Z

wallet/src/wallet/mod.rs

+            #[cfg(feature = "trezor")]
+            (WalletType::Ledger, WalletType::Ledger) => {}


feature = "ledger"?

ImplOfAnImpl · 2026-01-15T21:12:51Z

wallet/src/signer/ledger_signer/mod.rs

+        ChainType::Signet => CoinType::Regtest,
+        ChainType::Regtest => CoinType::Signet,


The opposite

ImplOfAnImpl · 2026-01-15T21:14:47Z

common/src/primitives_converters.rs

+    fn try_convert_from(value: VRFPublicKey) -> Result<Self, PrimitivesConvertersError> {
+        match value.kind() {
+            VRFKeyKind::Schnorrkel => {
+                let key: SchnorrkelPublicKey = value.try_into().unwrap();


Return an error instead of unwrapping

ImplOfAnImpl · 2026-01-15T21:14:53Z

common/src/primitives_converters.rs

+    fn try_convert_from(value: PublicKey) -> Result<Self, PrimitivesConvertersError> {
+        match value.kind() {
+            KeyKind::Secp256k1Schnorr => {
+                let key: Secp256k1PublicKey = value.try_into().unwrap();


Return an error instead of unwrapping

ImplOfAnImpl · 2026-01-16T12:47:04Z

.github/workflows/build.yml

+
+      - name: Update local dependency repositories
+        run: sudo apt-get update


"Update the list of available system packages"

wallet/src/signer/trezor_signer/mod.rs

wallet/src/signer/mod.rs

wallet/types/src/hw_data.rs

wallet/wallet-controller/src/types/mod.rs

ImplOfAnImpl · 2026-01-22T15:56:01Z

Forgot to mention: I wasn't able to open a ledger wallet in wallet-cli via the --wallet-file argument: "Wallet controller error: Wallet error: Key chain error: Wallet database error: Wallet file corrupted root keys expected 1 got 0"

OBorce changed the base branch from master to refactor/wallet-async-signing July 30, 2025 13:35

OBorce force-pushed the feature/ledger_signer branch 2 times, most recently from ecf51c0 to abe8a88 Compare July 31, 2025 08:24

OBorce force-pushed the refactor/wallet-async-signing branch from 59bd742 to 9099e90 Compare August 22, 2025 10:57

OBorce force-pushed the feature/ledger_signer branch from abe8a88 to 89285d1 Compare August 22, 2025 10:58

OBorce marked this pull request as ready for review August 25, 2025 12:43

OBorce requested review from ImplOfAnImpl and erubboli as code owners August 25, 2025 12:43

OBorce force-pushed the feature/ledger_signer branch from 5f20a4f to 4c64407 Compare August 25, 2025 12:56

ImplOfAnImpl reviewed Aug 28, 2025

View reviewed changes

OBorce force-pushed the refactor/wallet-async-signing branch 3 times, most recently from f21e82b to 75ff652 Compare September 18, 2025 22:31

OBorce force-pushed the feature/ledger_signer branch 4 times, most recently from 61292c5 to eeb6484 Compare September 23, 2025 22:28

OBorce marked this pull request as draft September 25, 2025 08:51

OBorce force-pushed the refactor/wallet-async-signing branch from 75ff652 to 96016cf Compare September 25, 2025 08:57

OBorce force-pushed the feature/ledger_signer branch 3 times, most recently from 5d3edf0 to d6fd484 Compare September 30, 2025 23:37

OBorce marked this pull request as ready for review October 1, 2025 07:09

OBorce force-pushed the feature/ledger_signer branch from 39d3e58 to d6fd484 Compare October 3, 2025 07:07

ImplOfAnImpl requested changes Oct 8, 2025

View reviewed changes

ImplOfAnImpl reviewed Oct 9, 2025

View reviewed changes

wallet/src/signer/ledger_signer/mod.rs Outdated Show resolved Hide resolved

ImplOfAnImpl reviewed Oct 9, 2025

View reviewed changes

wallet/src/signer/ledger_signer/mod.rs Outdated Show resolved Hide resolved

ImplOfAnImpl reviewed Oct 9, 2025

View reviewed changes

wallet/src/signer/ledger_signer/tests.rs Outdated Show resolved Hide resolved

OBorce force-pushed the feature/ledger_signer branch from d6fd484 to 2d5300b Compare October 26, 2025 23:34

OBorce changed the base branch from refactor/wallet-async-signing to master October 26, 2025 23:39

ImplOfAnImpl approved these changes Jan 22, 2026

View reviewed changes

OBorce force-pushed the feature/ledger_signer branch 4 times, most recently from dc2fca1 to 6c41a39 Compare February 10, 2026 08:02

OBorce mentioned this pull request Feb 11, 2026

bump ml_primitives and add more tests #1996

Closed

OBorce added 21 commits February 11, 2026 16:14

Add ledger signer

72f898c

fix ledger tests

f1b9a67

ledger cleanup

ebb748c

Remove podman usage from Ledger tests, fix comments

8e8fc2c

Use the new ledger messages

9546fb7

Add Ledger signer provider

863a17c

Add ledger support in CLI and GUI wallet

6cc8338

Add ledger CI tests

7fb4fe4

fix comments

620f8c7

Fix comments

36f91d9

Add support for Flex and Stax Ledger emulator tests

2b9dfc2

Use new ledger messages

5e3f47d

fix comments

2beb8b0

bump ml_primitives and add more tests

6d21d74

use primitive conversions

90ab8e6

fix missed comments

0adfae9

update ledger lib fork

8fda63c

fix after rebase

fc99eb7

Fix comments

b34d37c

Check wallet type for software signer

349f481

update CHANGELOG

7520c43

OBorce force-pushed the feature/ledger_signer branch from 6c41a39 to 7520c43 Compare February 11, 2026 11:18

update cargo vet

aa1a1a6

		#[cfg(feature = "trezor")]
		(WalletType::Ledger, WalletType::Ledger) => {}

		ChainType::Signet => CoinType::Regtest,
		ChainType::Regtest => CoinType::Signet,


		- name: Update local dependency repositories
		run: sudo apt-get update

Feature/ledger signer #1944

Are you sure you want to change the base?

Feature/ledger signer #1944

Uh oh!

Conversation

OBorce commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ImplOfAnImpl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ImplOfAnImpl left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ImplOfAnImpl commented Jan 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

OBorce commented Jul 30, 2025 •

edited

Loading