PeerBlockSyncManager: check block existence in separate chainstate call
#2009
+380
−38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PeerBlockSyncManagernow checks whether the block already exists via a separate chainstate subsystem call, which should reduce pressure on the chainstate during IBD.I also added a few tests:
PeerBlockSyncManageralways checks for block existence right before callingprocess_block.EventsControllerinutils, to ensure that events are handled in the same order as they are broadcast.