server: add maxBodyBytes guard for streamable HTTP#1498
Closed
TheodorNEngoy wants to merge 1 commit intomodelcontextprotocol:mainfrom
Closed
server: add maxBodyBytes guard for streamable HTTP#1498TheodorNEngoy wants to merge 1 commit intomodelcontextprotocol:mainfrom
TheodorNEngoy wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 7ec9f3e The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebStandardStreamableHTTPServerTransportcurrently parses POST bodies viaawait req.json(), which buffers the full request body in memory.This PR adds a
maxBodyBytesoption (default:1_000_000) and enforces it when parsing JSON bodies. Oversized payloads return 413.maxBodyBytestoWebStandardStreamableHTTPServerTransportOptions(negative disables)Content-Lengthreject when present)413with JSON error response (-32_000, "Payload too large")Note: if callers pass
parsedBodytohandleRequest, they must enforce limits in their framework/body parser.