Run validators only for root object in xPDOObjectVehicle install#267
Merged
opengeek merged 1 commit intomodxcms:3.xfrom Mar 8, 2026
Merged
Conversation
Validators are vehicle-level and were incorrectly invoked for each related object (1 + N times). Now validate() runs only when $parentObject === null (root object installation). Resolves modxcms/revolution#16223
opengeek
changed the title
opengeek
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
In
xPDOObjectVehicle::_installObject(), validation is now run only when installing the root object ($parentObject === null). For related objects ($parentObject !== null), validation is skipped since validators are vehicle-level and already executed for the root.Change:
if ($parentObject !== null || $this->validate($transport, $object, $vOptions))Why is it needed?
Vehicle validators were invoked for every
_installObject()call—once for the root and once per related object (e.g. Plugin + 2 PluginEvents = 3 times). The same validator script ran repeatedly, causing duplicate messages and unnecessary work.How to test
false.Related issue(s)/PR(s)
Resolves modxcms/revolution#16223