fix(ImportResults): add default value for updated_rows_count prop#2325
Open
joshtrichards wants to merge 1 commit intomainfrom
Open
fix(ImportResults): add default value for updated_rows_count prop#2325joshtrichards wants to merge 1 commit intomainfrom
joshtrichards wants to merge 1 commit intomainfrom
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
added
bug
Contributor
|
/backport to stable1.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probably overlooked when #1824 was implemented.
Tests for the feature only seem to cover scenarios where
updated_rows_countis >1 (i.e. provided by the back-end).Low impact; not worth adding tests for at the moment, but a bug nonetheless.