-
Notifications
You must be signed in to change notification settings - Fork 522
add pkg-config support for exporters #3829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add pkg-config support for exporters #3829
Conversation
Signed-off-by: Harish <[email protected]>
Signed-off-by: Harish <[email protected]>
Signed-off-by: Harish <[email protected]>
Signed-off-by: Harish <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3829 +/- ##
=======================================
Coverage 89.95% 89.95%
=======================================
Files 225 225
Lines 7170 7170
=======================================
Hits 6449 6449
Misses 721 721 🚀 New features to boost your workflow:
|
Signed-off-by: Harish <[email protected]>
Signed-off-by: Harish <[email protected]>
Signed-off-by: Harish <[email protected]>
Signed-off-by: Harish <[email protected]>
Co-authored-by: Tom Tan <[email protected]>
|
Could we call |
|
@owent I have taken an example with the ostream exporter: We have 2 components but need 6 pkgconfig files: Components: Pkgconfig: We would need to specify a description along with dependencies for each target when calling |
|
Thanks for the PR. Could you also update |
Signed-off-by: Harish <[email protected]>
Signed-off-by: Harish <[email protected]>
| for protocol in grpc http file; do | ||
| validate_package "opentelemetry_exporter_otlp_${protocol}" | ||
| for variant in client builder log log_builder metrics metric_builder; do | ||
| validate_package "opentelemetry_exporter_otlp_${protocol}_${variant}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks for opentelemetry_exporter_otlp_http_metrics but the actual package is opentelemetry_exporter_otlp_http_metric. The script is successful as "--exists" check will filter it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I addressed this by splitting it into two different loops as the grpc library ends with _metrics, but http and file end with _metric.
Signed-off-by: Harish <[email protected]>
Signed-off-by: Harish <[email protected]>
Signed-off-by: Harish <[email protected]>
Fixes #3787
Changes
Adds pkg-config support for the following exporters exporters:
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes