Conversation
Added dyslexdria " World "
Added dyslexdria " World "
|
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdds two new maps, Dyslexdria and Conakry: JSON map assets and manifests, registers both in the game map enum and categories, updates English localization entries for both maps, and adds small placeholder temp files for Conakry. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
map-generator/assets/maps/dyslexdria/info.json (1)
74-78: Inconsistent indentation on two entries.Lines 74 and 194 have non-standard leading whitespace compared to the rest of the array (4-space indent). Minor cosmetic issue.
✏️ Proposed fix
- { + { "coordinates": [1370, 670], "flag": "ae", "name": "United Bara Estimates" },- { + { "coordinates": [1950, 1305], "flag": "aq", "name": "Nort Pole" },Also applies to: 194-198
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@map-generator/assets/maps/dyslexdria/info.json` around lines 74 - 78, Two array entries have inconsistent leading whitespace; locate the JSON objects with "name": "United Bara Estimates" (coordinates [1370, 670], flag "ae") and the other entry referenced in the comment (lines ~194-198) and normalize their indentation to match the rest of the array (use 4-space indentation for the object opening line and its properties) so the file's formatting is consistent.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@resources/lang/en.json`:
- Line 329: The translation entry "dyslexdria" currently has leading/trailing
spaces (" World ") which will render visible whitespace; remove the surrounding
spaces so the display string is "World" and ensure any uniqueness/joke is
handled on the enum value (see Game.ts around the enum at line ~120) rather than
by injecting whitespace into the user-facing string; update the "dyslexdria"
value only (and adjust the enum value in Game.ts if needed) so UI displays
"World" cleanly.
---
Nitpick comments:
In `@map-generator/assets/maps/dyslexdria/info.json`:
- Around line 74-78: Two array entries have inconsistent leading whitespace;
locate the JSON objects with "name": "United Bara Estimates" (coordinates [1370,
670], flag "ae") and the other entry referenced in the comment (lines ~194-198)
and normalize their indentation to match the rest of the array (use 4-space
indentation for the object opening line and its properties) so the file's
formatting is consistent.
| "surrounded": "Surrounded", | ||
| "didier": "Didier", | ||
| "didierfrance": "Didier (France)", | ||
| "dyslexdria": " World ", |
There was a problem hiding this comment.
Display value " World " with surrounding spaces will render with visible whitespace in the map selector.
Every other map entry has a clean display string. The leading/trailing spaces here will appear as extra padding around the map name in the UI, which reads as a rendering bug. If the intent is to call it "World" (to create the joke), the unique disambiguation should live at the enum-value level (see the comment on Game.ts line 120), not by injecting whitespace into the user-visible display string.
💡 Proposed fix (after fixing the enum value)
- "dyslexdria": " World ",
+ "dyslexdria": "World",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "dyslexdria": " World ", | |
| "dyslexdria": "World", |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@resources/lang/en.json` at line 329, The translation entry "dyslexdria"
currently has leading/trailing spaces (" World ") which will render visible
whitespace; remove the surrounding spaces so the display string is "World" and
ensure any uniqueness/joke is handled on the enum value (see Game.ts around the
enum at line ~120) rather than by injecting whitespace into the user-facing
string; update the "dyslexdria" value only (and adjust the enum value in Game.ts
if needed) so UI displays "World" cleanly.
github-project-automation
bot
moved this from Triage
to Development
in OpenFront Release Management
|
@patrickbadly-hub would you please include a photo of the map? |
|
Im not sure how to add it without resubmitting. Here is the correct thumbnail. Sorry for the delay |
Original Thumbnail Uploaded
iiamlewis
added
the
Maps
|
Please let me know if I need to do anything else. Have a good day |
Add folder conakry
Added Conakry assets to map gen folder
creating conakry folder
Add folder conakry
Added resources for map conakry
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@map-generator/assets/maps/conakry/info.json`:
- Around line 1-115: This PR accidentally adds a new map asset
assets/maps/conakry/info.json (map name "conakry") which will cause
map-generator/main.go to produce unwanted generated artifacts; either remove
this file from the PR entirely, or if you intend to add the Conakry map, include
the corresponding generated outputs produced by map-generator/main.go plus the
runtime game/map registration (the same place where "Dyslexdria" is registered)
so the new map is fully wired in the same PR.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 2701bb4d-5a8e-44aa-bbda-ca862bedf8cb
⛔ Files ignored due to path filters (1)
map-generator/assets/maps/conakry/image.pngis excluded by!**/*.png
📒 Files selected for processing (1)
map-generator/assets/maps/conakry/info.json
| { | ||
| "name": "conakry", | ||
| "nations": [ | ||
| { | ||
| "coordinates": [20, 360], | ||
| "name": "Boffa", | ||
| "flag": "gn" | ||
| }, | ||
| { | ||
| "coordinates": [510, 420], | ||
| "name": "Koba-Tatema", | ||
| "flag": "gn" | ||
| }, | ||
| { | ||
| "coordinates": [680, 150], | ||
| "name": "Kenende", | ||
| "flag": "gn" | ||
| }, | ||
| { | ||
| "coordinates": [1170, 30], | ||
| "name": "Dubreka", | ||
| "flag": "gn" | ||
| }, | ||
| { | ||
| "coordinates": [1280, 280], | ||
| "name": "Tamouta", | ||
| "flag": "gn" | ||
| }, | ||
| { | ||
| "coordinates": [1320, 550], | ||
| "name": "Ratoma", | ||
| "flag": "gn" | ||
| }, | ||
| { | ||
| "coordinates": [1350, 40], | ||
| "name": "Coyah", | ||
| "flag": "gn" | ||
| }, | ||
| { | ||
| "coordinates": [1630, 160], | ||
| "name": "Maferenya", | ||
| "flag": "gn" | ||
| }, | ||
| { | ||
| "coordinates": [1730, 460], | ||
| "name": "Kaback", | ||
| "flag": "gn" | ||
| }, | ||
| { | ||
| "coordinates": [2130, 80], | ||
| "name": "Forecariah", | ||
| "flag": "gn" | ||
| }, | ||
| { | ||
| "coordinates": [2420, 424], | ||
| "name": "Benty", | ||
| "flag": "gn" | ||
| }, | ||
| { | ||
| "coordinates": [2280, 440], | ||
| "name": "Laya", | ||
| "flag": "gn" | ||
| }, | ||
| { | ||
| "coordinates": [1200, 910], | ||
| "name": "Fotoba", | ||
| "flag": "gn" | ||
| }, | ||
| { | ||
| "coordinates": [1333, 835], | ||
| "name": "Ilot Cabri", | ||
| "flag": "gn" | ||
| }, | ||
| { | ||
| "coordinates": [716, 260], | ||
| "name": "Bolonta", | ||
| "flag": "gn" | ||
| }, | ||
| { | ||
| "coordinates": [870, 370], | ||
| "name": "Kanka", | ||
| "flag": "gn" | ||
| }, | ||
| { | ||
| "coordinates": [940, 115], | ||
| "name": "Mangueya", | ||
| "flag": "gn" | ||
| }, | ||
| { | ||
| "coordinates": [1975, 475], | ||
| "name": "Yelibane", | ||
| "flag": "gn" | ||
| }, | ||
| { | ||
| "coordinates": [1900, 115], | ||
| "name": "Dandaya", | ||
| "flag": "gn" | ||
| }, | ||
| { | ||
| "coordinates": [80, 480], | ||
| "name": "Marara", | ||
| "flag": "gn" | ||
| }, | ||
| { | ||
| "coordinates": [390, 210], | ||
| "name": "Boufou", | ||
| "flag": "gn" | ||
| }, | ||
| { | ||
| "coordinates": [180, 130], | ||
| "name": "Dioumaya", | ||
| "flag": "gn" | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
Remove the unrelated conakry generator asset from this PR.
This PR is wired for Dyslexdria, but this file adds a second map source named conakry. map-generator/main.go turns each assets/maps/<name>/info.json into generated map output, so keeping this here makes future generation produce conakry artifacts that are not part of the runtime map registration in this change. Please drop this file from the PR, or add the matching generated resources and game registration in the same PR if conakry is intentional.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@map-generator/assets/maps/conakry/info.json` around lines 1 - 115, This PR
accidentally adds a new map asset assets/maps/conakry/info.json (map name
"conakry") which will cause map-generator/main.go to produce unwanted generated
artifacts; either remove this file from the PR entirely, or if you intend to add
the Conakry map, include the corresponding generated outputs produced by
map-generator/main.go plus the runtime game/map registration (the same place
where "Dyslexdria" is registered) so the new map is fully wired in the same PR.
Added map name "conakry"
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@resources/maps/conakry/manifest.json`:
- Around line 1-196: The conakry map assets are unreachable because GameMapType
lacks a Conakry entry and mapCategories in src/core/game/Game.ts doesn't
register it; add Conakry = "Conakry" to the GameMapType enum and include
GameMapType.Conakry in the appropriate category inside mapCategories (e.g.,
regional or whichever category holds similar maps), or remove
resources/maps/conakry/manifest.json and its folder; ensure
FetchGameMapLoader.ts will resolve the lowercase "conakry" folder name by the
enum entry if you choose to register it.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 67b87816-a32c-479c-b22f-e3cfe4af09e5
⛔ Files ignored due to path filters (3)
resources/maps/conakry/map.binis excluded by!**/*.binresources/maps/conakry/map16x.binis excluded by!**/*.binresources/maps/conakry/map4x.binis excluded by!**/*.bin
📒 Files selected for processing (3)
resources/maps/conakry/manifest.jsonresources/maps/conakry/tempresources/maps/conakry/thumbnail.webp
✅ Files skipped from review due to trivial changes (1)
- resources/maps/conakry/temp
Add map conakry
|
I am deleting my fork of OpenFrontIO and will resubmit this Pull Request. Original submission was not branched. |
3 participants
Description: Submission of working map Dyslexdria.
Describe the PR.
-Pre edited map source is the high res world map provided in the MapGenerator files.
Please put your Discord username so you can be contacted if a bug or regression is found:
PlaysBadly
I've never done a pull request before, so feel free to check my work. This was tested on a local server using an up to date copy of the local git. I then manually updated my forked repository.