[chore] removed .env files from git tracking #21818
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NobodysNightmare
requested changes
Jan 30, 2026
Contributor
NobodysNightmare
left a comment
NobodysNightmare
left a comment
There was a problem hiding this comment.
🔴 erm... That's not how it works. Or rather how it's intended to work. Also see the docs that I added when introducing this.
The .env file provides default values that Docker Compose will assume, in case an environment variable with the corresponding value can't be found. Otherwise it would assume an empty string for those.
So the .env files have been added to make .local the default TLD, but if you want to customize that, don't touch the env files, but touch your environment.
E.g. in your bashrc (assuming you are a bash user), you could add
export OPENPROJECT_DOCKER_DEV_TLD=internal
(fish is probably similar, but I don't know how)
Member
Author
|
As discussed, I updated the PR with the fallback way of doing stuff. Have a look again. |
NobodysNightmare
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
.envfiles without making changes to the origin