Change PER_GROUP_ONLY to PER_GROUP and update P4Runtime spec#604
Open
matthewtlam wants to merge 1 commit intop4lang:mainfrom
Open
Change PER_GROUP_ONLY to PER_GROUP and update P4Runtime spec#604matthewtlam wants to merge 1 commit intop4lang:mainfrom
matthewtlam wants to merge 1 commit intop4lang:mainfrom
Conversation
Signed-off-by: Matthew Lam <matthew.lam.qwerty@gmail.com>
| ** `id`, the `uint32` identifier of the action. | ||
| ** `scope`, an enum value which can take one of four values: | ||
| `TABLE_AND_DEFAULT`, `TABLE_ONLY`, `PER_GROUP_ONLY` and `DEFAULT_ONLY`. The | ||
| `TABLE_AND_DEFAULT`, `TABLE_ONLY`, `PER_GROUP` and `DEFAULT_ONLY`. The |
Contributor
There was a problem hiding this comment.
Why not GROUP_ACTION?
Contributor
There was a problem hiding this comment.
Or, it seems sorta nice that they are the same...
Contributor
There was a problem hiding this comment.
Agreed that if @groupaction is the annotation, then GROUP_ACTION as the value of the enum would be nice to keep it similar to existing corresponding attribute/enum-value-names:
- @defaultonly -> DEFAULT_ONLY
- @tableonly -> TABLE_ONLY
- @groupaction -> GROUP_ACTION
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.