Treat macro level -14 as MACROFILES for ALT Linux rpm 4.13.0.1 bug

[shaba]

Add workaround for ALT Linux rpm bug

[gemini-code-assist]

Summary of Changes

Hello @shaba, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a compatibility fix for systems running ALT Linux with an older RPM version (4.13.0.1). It specifically addresses a bug where an incorrect macro level value (-14) is passed, by mapping this value to the expected MACROFILES level within the MacroLevel enumeration, ensuring correct macro processing.

Highlights

• RPM Bug Workaround: Implemented a specific workaround in the MacroLevel Enum to address a pushMacro(level - 1) bug found in older RPM version 4.13.0.1 on ALT Linux, by mapping the erroneous -14 value to MACROFILES.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a workaround for a bug in an older version of rpm on ALT Linux, where an incorrect macro level is used. The change correctly maps the erroneous value -14 to the MACROFILES level. The implementation is clean and uses Python's IntEnum._missing_ feature appropriately. I have one suggestion to add type hints to the new method for consistency with the existing code style.

[gemini-code-assist]

For consistency with the rest of the codebase and for improved type safety, it would be beneficial to add type hints to the _missing_ method signature.

Suggested change

	def _missing_(cls, value):
	def _missing_(cls, value: object) -> Optional["MacroLevel"]:

[centosinfra-prod-github-app]

Build succeeded.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/92ddb762fa8a48d3b75b4ddc013a7d2e

✔️ pre-commit SUCCESS in 2m 06s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 39s
✔️ specfile-tests-pip-deps SUCCESS in 1m 37s

[nforro]

Thanks, just please add the missing type hints, per gemini-code-assist suggestion.