Merged
Conversation
RemDelaporteMathurin
requested changes
Jul 31, 2025
Collaborator
RemDelaporteMathurin
left a comment
RemDelaporteMathurin
left a comment
There was a problem hiding this comment.
I tested this locally and confirm the data can be downloaded (tested on chrome) and plotted without issue.
I just have a few requests (see comments below)
src/backend.py
Outdated
Comment on lines
116
to
127
| csv_payload = { | ||
| "time": [], | ||
| "series": {} | ||
| } | ||
| max_len = 0 | ||
| for scope in scopes: | ||
| time, values = scope.read() | ||
| max_len = max(max_len, len(time)) | ||
| csv_payload["time"] = time.tolist() | ||
| for i, series in enumerate(values): | ||
| label = scope.labels[i] if i < len(scope.labels) else f"{scope.label} {i}" | ||
| csv_payload["series"][label] = series.tolist() |
Collaborator
There was a problem hiding this comment.
This could be its own function make_csv_payload(scopes) that can then be tested in the CI
Closed
RemDelaporteMathurin
approved these changes
Aug 1, 2025
Collaborator
RemDelaporteMathurin
left a comment
RemDelaporteMathurin
left a comment
There was a problem hiding this comment.
LGTM, we can probably work later on making the results graph a bit smaller in some cases. Feel free to merge it if you're happy with it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.