-
Notifications
You must be signed in to change notification settings - Fork 378
feat(NotificationBadge): add support for plain variant #12139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Preview: https://pf-react-pr-12139.surge.sh A11y report: https://pf-react-pr-12139-a11y.surge.sh |
thatblindgeye
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An isPlain flag might slightly make more sense? As a value "plain" is pretty different from the other variant values, though at the same time we'd most likely have the logic setup the way it is in the PR now (I don't think we'd want a plain NotificationBadge to have the "attention" icon for example). I think it's good as-is, though.
|
Did we ever get design approval? I see the question in #12069 but no response |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
I didn't see a toggle for isPlain like in other examples. I was able to see the changes by applying the variant="plain" |


What: Closes #12066
Currently I've added support for "plain" based on the issue's usage (adding it to the existing
variantprop), but I'm wondering whether this may be better as a separateisPlainflag. Though the NotificationBadge props are not 1:1 with Button's props, so maybe adding it as part of thevariantprop is still fine. LMK if anyone has thoughts or preferences about one method or another.