fix: handle keyboard shortcut for text filter#594
Open
CodyWMitchell wants to merge 2 commits intopatternfly:mainfrom
Open
fix: handle keyboard shortcut for text filter#594CodyWMitchell wants to merge 2 commits intopatternfly:mainfrom
CodyWMitchell wants to merge 2 commits intopatternfly:mainfrom
Conversation
nicolethoen
approved these changes
Feb 3, 2026
nicolethoen
reviewed
Feb 3, 2026
Contributor
nicolethoen
left a comment
There was a problem hiding this comment.
since this component attaches a window-level event listener, consuming applications don't currently have a way to opt out of this behavior.
This could be problematic in scenarios where:
- The application wants to manage keyboard shortcuts at a higher level (e.g.,
in a centralized keyboard handler) - Multiple
DataViewTextFilterinstances exist on the same page, causing
multiple listeners to fire - The
/shortcut conflicts with existing application shortcuts
Could we consider an optional prop in case they want more fine tuned control over this feature?
export interface DataViewTextFilterProps extends SearchInputProps {
// ... existing props
/** Enable keyboard shortcut (/) to focus the filter. Defaults to true. */
enableShortcut?: boolean;
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle keyboard shortcut for text filter
/will focus the text filterOCPBUGS-63391