test: modernize test suite and remove obsolete tests#93
Open
Phillip9587 wants to merge 1 commit intopillarjs:masterfrom
Open
test: modernize test suite and remove obsolete tests#93Phillip9587 wants to merge 1 commit intopillarjs:masterfrom
Phillip9587 wants to merge 1 commit intopillarjs:masterfrom
Conversation
Phillip9587
commented
Mar 31, 2025
test/test.js
Outdated
Comment on lines
-616
to
-662
|
|
||
| describe('no deprecation warnings', function () { | ||
| it('should respond 404 on no error', function (done) { | ||
| var warned = false | ||
|
|
||
| process.once('warning', function (warning) { | ||
| if (/The http2 module is an experimental API/.test(warning)) return | ||
| assert.fail(warning) | ||
| }) | ||
|
|
||
| wrapper(request(createServer()) | ||
| .head('/foo')) | ||
| .expect(404) | ||
| .end(function (err) { | ||
| assert.strictEqual(warned, false) | ||
| done(err) | ||
| }) | ||
| }) | ||
|
|
||
| it('should respond 500 on error', function (done) { | ||
| var warned = false | ||
|
|
||
| process.once('warning', function (warning) { | ||
| if (/The http2 module is an experimental API/.test(warning)) return | ||
| assert.fail(warning) | ||
| }) | ||
|
|
||
| var err = createError() | ||
|
|
||
| wrapper(request(createServer(function (req, res) { | ||
| var done = finalhandler(req, res) | ||
|
|
||
| if (typeof err === 'function') { | ||
| err(req, res, done) | ||
| return | ||
| } | ||
|
|
||
| done(err) | ||
| })) | ||
| .head('/foo')) | ||
| .expect(500) | ||
| .end(function (err, res) { | ||
| assert.strictEqual(warned, false) | ||
| done(err) | ||
| }) | ||
| }) | ||
| }) |
Contributor
Author
There was a problem hiding this comment.
These tests can be removed, as using http2 no longer emits an experimental warning in any of our supported Node.js versions.
bjohansebas
reviewed
Apr 26, 2025
| req.on('data', function ondata (s) { buf += s }) | ||
| req.on('end', function onend () { | ||
| var err = null | ||
| req.on('response', (responseHeaders) => { resHeaders = responseHeaders }) |
Member
There was a problem hiding this comment.
I would prefer that we keep the regular function, it's easier to debug when you know the function name rather than when it's an anonymous function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several refactorings and updates to the test suite, focusing on modernizing the codebase by adopting ES6+ features and improving the structure of test utilities. The most important changes include refactoring utility functions, and updating test cases to use the new utility structure.
ES6+ Modernization:
test/support/sws.js: ConvertedSlowWriteStreamfrom a function andutil.inheritsto an ES6 class extendingWritable.Refactoring Utility Functions:
test/support/utils.js: Refactored various utility functions to use ES6 syntax, replacedvarwithconst/let, and consolidated exports into a singlegetTestHelpersfunction. [1] [2] [3] [4] [5]Updating Test Cases:
test/test.js: Updated test cases to use the newgetTestHelpersfunction, removed redundantwrapperfunction, and replacedvarwithconst/letfor variable declarations. [1] [2] [3] [4] [5]