Add policy support for DELETE operations#628
Open
chandrasekharmalladi wants to merge 1 commit intoplexsystems:mainfrom
Open
Add policy support for DELETE operations#628chandrasekharmalladi wants to merge 1 commit intoplexsystems:mainfrom
chandrasekharmalladi wants to merge 1 commit intoplexsystems:mainfrom
Conversation
Collaborator
|
Thanks for the PR, but I have concerns about the impact. This has a high likelihood to break people's workflows if they are already using konstraint and don't care about DELETE operations. With this change, it would actually prevent people from deleting resources that violate policy. |
Author
|
Hey @jalseth, apologies for getting back late. Thank you for reviewing the MR. I see what you mean, I tested it and it indeed blocks people from deleting resources that violate the policy. The workarounds I can think of would need all the "non-delete" examples to explicitly define the operation. Are there any other ways you could recommend to solve this problem? I am trying to have some OPA policies to block deletion of some key resources. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change extends the core Rego library to support safely handling
input.review.oldObject, andinput.review.operation.Details
Updates
resourceto use:input.review.objectif presentinput.review.oldObjectin case of DELETE operations.Adds logic to expose
core.operationusing:input.review.operationfor GatekeeperWhy
Gatekeeper policies for
DELETEoperations often need access to:The previous state (
review.oldObject) - Gatekeeper input structure referenceThe operation type (
review.operation)Example Use Case
A policy can now safely evaluate: