Add types from @types/plotly.js-dist-min, Typing update, Export PlotlyViaWindow and PlotlyViaCDN#288
Open
bzh2610 wants to merge 4 commits intoplotly:masterfrom
Open
Add types from @types/plotly.js-dist-min, Typing update, Export PlotlyViaWindow and PlotlyViaCDN#288bzh2610 wants to merge 4 commits intoplotly:masterfrom
bzh2610 wants to merge 4 commits intoplotly:masterfrom
Conversation
bzh2610
changed the title
bzh2610
changed the title
bzh2610
changed the title
bzh2610
changed the title
bzh2610
commented
Oct 2, 2025
Comment on lines
-3
to
-5
| export type Data = any; | ||
| export type Layout = any; | ||
| export type Config = any; |
Author
There was a problem hiding this comment.
Removing this to use @type/plotly.js-dist-min
Comment on lines
+6
to
+7
| export * from './lib/plotly-via-cdn.module'; | ||
| export * from './lib/plotly-via-window.module'; |
Author
There was a problem hiding this comment.
Undoing (accidental ?) Removal of this ? See issue linked in description
bzh2610
commented
Oct 2, 2025
Comment on lines
+18
to
+21
| {x: [1, 2, 3], y: [2, 6, 3], type: 'scatter', mode: 'lines+markers', marker: {color: 'red'}}, | ||
| {x: [1, 2, 3], y: [2, 5, 3], type: 'bar'}, | ||
| ], | ||
| layout: {width: 320, height: 240, title: 'A Fancy Plot'} | ||
| layout: {width: 320, height: 240, title: { text: 'A Fancy Plot'} } |
Author
There was a problem hiding this comment.
With new stronger types, this was compiling anymore, I had to update the sample
bzh2610
commented
Oct 2, 2025
| { | ||
| "name": "angular-plotly.js", | ||
| "version": "20.0.0", | ||
| "version": "20.1.0", |
Author
There was a problem hiding this comment.
Suggesting increment to release this, feel free to comment if it should be done in a separate PR/commit
|
any updates on release date? |
Author
|
@afarzat-ed are you still maintaining this repository ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
@types/plotly.js-dist-minSince the README instructs us to use those types :
We might as well use those types for a better coherence with the latest updates and stronger typing
Also :
coverallsas it's unusedplotly.js-dist(in favor of the minified package)titleproperty change)Using types from the types library allows for smartter auto-completion :
(This used to be any[] with the previous definition from interface.ts)