Fix annotation bug in plotly_build.R#2411
Open
ellenbouchard wants to merge 1 commit intoplotly:masterfrom
Open
Fix annotation bug in plotly_build.R#2411ellenbouchard wants to merge 1 commit intoplotly:masterfrom
ellenbouchard wants to merge 1 commit intoplotly:masterfrom
Conversation
Fixed a bug in which, if the plot only has one annotation but the 'font' attribute has multiple elements (such as color and size), the annotation becomes duplicated. This was due to the fact that plotly_build, when counting annotations, also counted the length of the 'font' attribute list, so if there's only one annotation but 'font' is of length 2, it created a list of 2 identical annotations. Now, when counting the length of annotation attributes, any attribute of class 'list' (which I believe should only apply to 'font'), is removed and not counted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug in which, if the plot only has one annotation but the 'font' attribute has multiple elements (such as color and size), the annotation becomes duplicated. This was due to the fact that plotly_build, when counting annotations, also counted the length of the 'font' attribute list, so if there's only one annotation but 'font' is of length 2, it created a list of 2 identical annotations.
Now, when counting the length of annotation attributes, any attribute of class 'list' (which I believe should only apply to 'font'), is removed and not counted.