feat: ✨ add new command 'm365 pp pipeline list' to list Powe…#6434
feat: ✨ add new command 'm365 pp pipeline list' to list Powe…#6434
Conversation
|
Thank you @DevPio m, we'll try to review it ASAP! |
Adam-it
added
the
hacktoberfest-accepted
|
@DevPio I added the |
martinlingstuyl
left a comment
martinlingstuyl
left a comment
There was a problem hiding this comment.
Hi @DevPio, I've reviewed your PR, let's fix some issues before we move on!
|
@martinlingstuyl everything looks good to me. If you notice any other issues, feel free to let me know |
martinlingstuyl
left a comment
martinlingstuyl
left a comment
There was a problem hiding this comment.
Hi @DevPio! I've looked through the files. We're getting there. Let's fix a last couple of things before we merge this.
|
|
||
| ## Options | ||
|
|
||
| `-e, --environmentName <environment>` |
There was a problem hiding this comment.
You're missing the line ```md definition-list above this line. Do compare with other mdx files to see. And if you want you can build the docs and serve them locally to see if the page looks correctly...
|
|
||
| `--asAdmin` | ||
| : Run the command as admin and retrieve pipelines from environments you do not have explicitly assigned permissions to. | ||
|
|
There was a problem hiding this comment.
A closing ``` is necessary just below the last option and before the <Global/> component
| ``` | ||
|
|
||
| </TabItem> | ||
|
|
There was a problem hiding this comment.
Let's remove superfluous line breaks like this one.
| } | ||
|
|
||
| public get description(): string { | ||
| return 'Lists Microsoft Power Platform pipelines in the specified Power Platform environment.'; |
There was a problem hiding this comment.
Let's use the exact same description as is in the docs file.
| } | ||
|
|
||
| public async commandAction(logger: Logger, args: any): Promise<void> { | ||
|
|
There was a problem hiding this comment.
Let's remove this superfluous line break
| catch (ex: any) { | ||
| this.handleRejectedODataJsonPromise(ex); | ||
| } | ||
|
|
There was a problem hiding this comment.
Let's remove this superfluous line break
| } | ||
|
|
||
| private async listPipelines(instanceUrl: string): Promise<any> { | ||
|
|
There was a problem hiding this comment.
Let's remove this superfluous line break
|
|
||
| return pipelines.value; | ||
| } | ||
|
|
There was a problem hiding this comment.
Let's remove this sup... you get the gist of it :-)
| }); | ||
| } | ||
|
|
||
| #initOptions(): void { |
There was a problem hiding this comment.
I overlooked this the previous review, but you're actually using the older setup of options and validation. We've since moved to zod, which is a tool to help parse options and validate the schema.
Would you mind reworking this command so that it aligns with the new way of working on this count? You can find a good example in recyclebinitem-restore.ts.
| } | ||
| }), new CommandError(errorMessage)); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Let's remove this linebreak as well.. and i see another couple of line breaks that can be removed here.
|
Hi @DevPio, Is this something you might try to fix, or should I unassign me? Do let me know, and no hard feelings if you can't make time! |
| @@ -0,0 +1,105 @@ | |||
| import Global from '/docs/cmd/_global.mdx'; | |||
There was a problem hiding this comment.
Hi, due to PR #7160, it is crucial that we reference this page using a relative path. Could you update this import, please? Much appreciated!
4 participants
Closes #6287