Skip to content

Core: disabling fingerprinting apis#14404

Open
mkomorski wants to merge 2 commits intomasterfrom
fingerprinting
Open

Core: disabling fingerprinting apis#14404
mkomorski wants to merge 2 commits intomasterfrom
fingerprinting

Conversation

@mkomorski
Copy link
Collaborator

Provides new config flag disableFingerprintingApis

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Other information

#14283

if (isFingerprintingApiDisabled('webdriver')) {
return false;
}
return getFallbackWindow(win).navigator?.webdriver === true;

Check warning

Code scanning / CodeQL

Use of browser API associated with fingerprinting Warning

navigator.webdriver is an indicator of fingerprinting; weight: 28.99
deepSetNotEmptyValue(qs, '51D_ScreenPixelsHeight', _window?.screen?.height);
deepSetNotEmptyValue(qs, '51D_ScreenPixelsWidth', _window?.screen?.width);
deepSetNotEmptyValue(qs, '51D_PixelRatio', _window?.devicePixelRatio);
deepSetNotEmptyValue(qs, '51D_PixelRatio', getDevicePixelRatio(_window));

Check warning

Code scanning / CodeQL

Use of browser API associated with fingerprinting Warning

devicePixelRatio is an indicator of fingerprinting; weight: 18.84
@mkomorski mkomorski marked this pull request as ready for review February 4, 2026 10:01
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 21666852693

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 46 of 53 (86.79%) changed or added relevant lines in 8 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.001%) to 96.219%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/webdriver/webdriver.js 9 10 90.0%
test/spec/fingerprinting_spec.js 26 32 81.25%
Files with Coverage Reduction New Missed Lines %
modules/excoBidAdapter.js 1 78.17%
modules/adkernelBidAdapter.js 9 94.64%
Totals Coverage Status
Change from base Build 21543726290: -0.001%
Covered Lines: 209202
Relevant Lines: 217422

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants