fix: moment.js loaded globally but only used in search#786
Closed
Parth-Garg2629 wants to merge 3 commits intoprecice:masterfrom
Closed
fix: moment.js loaded globally but only used in search#786Parth-Garg2629 wants to merge 3 commits intoprecice:masterfrom
Parth-Garg2629 wants to merge 3 commits intoprecice:masterfrom
Conversation
Parth-Garg2629
force-pushed
the
fix/moment-js-scope-to-search
branch
from
b232a77 to
187ccad
Compare
Member
|
See issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
moment.js(~17KB) was loaded unconditionally on every page via _includes/head.html, but it is only used in _includes/algolia.html (line 20) to format dates in search results.Changes
<script src="...moment.min.js">from _includes/head.htmlmoment.unix(...).format(...)Why
This removes a hidden global dependency and co-locates the library with its only consumer. It also prepares the codebase for conditionally loading the search widget (and its deps) in the future.
Testing
moment.jsis still loaded as part of the search widget includeCloses #785