refactor: move Algolia search box styles from JS to CSS#804
Open
Parth-Garg2629 wants to merge 1 commit intoprecice:masterfrom
Open
refactor: move Algolia search box styles from JS to CSS#804Parth-Garg2629 wants to merge 1 commit intoprecice:masterfrom
Parth-Garg2629 wants to merge 1 commit intoprecice:masterfrom
Conversation
MakisH
added
GSoC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Algolia search box was styled via JS (
elem.style.*calls) inalgolia-search.js, with a comment acknowledging this was a workaround. The equivalent CSS was already written — just commented out in the same file.This PR moves those styles into the existing Search section of
css/customstyles-precice.cssand removes the JS style injection and the dead commented CSS block.No visual changes — styles are identical.