This repository was archived by the owner on Dec 27, 2021. It is now read-only.
Added ability to specify return codes.#140
Open
jbzdak wants to merge 1 commit intopython-provy:masterfrom
Open
Added ability to specify return codes.#140jbzdak wants to merge 1 commit intopython-provy:masterfrom
jbzdak wants to merge 1 commit intopython-provy:masterfrom
Conversation
Contributor
Author
|
This requires some more work, it breaks some existing functionality. For now it overrrides any warn_only setting set by any other code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When getting returncode other than 0
fabricraisesSystemExiterror by default, which is very unformtuate, since it is one exception you really shouldn't catch in Python.You can of course use
fabric.api.settings(warn_only=True, but you have to know of its existence, which can be hard. And we force user to use api other thanprovyapi. I added a small feature that allows user to specify return codes that are considered as succesfull execurion, and if process return other return code I raise saneCommandExecutionError).Let me know if any further changes are neccessary.