Accept reversed dataclass field-order warning#2152
Merged
carljm merged 1 commit intopython:mainfrom Jan 29, 2026
Merged
Conversation
|
All commit authors signed the Contributor License Agreement. |
srittau
added
the
topic: conformance tests
JelleZijlstra
approved these changes
Jan 20, 2026
Extend PyTypingConformanceTest to allow the alternative diagnostic emitted when a dataclass field with a default precedes a field without a default. Both messages represent the same semantic error but differ in field-order phrasing.
carljm
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed for PyCharm, where the dataclass field-order diagnostic can be emitted in the inverse form depending on
analysis order.
The change makes the typing conformance test robust to both equivalent warnings.