[WIP] Initial support for a plot area with multiple different charts on it#341
Open
pnomolos wants to merge 3 commits intorandym:masterfrom
Open
[WIP] Initial support for a plot area with multiple different charts on it#341pnomolos wants to merge 3 commits intorandym:masterfrom
pnomolos wants to merge 3 commits intorandym:masterfrom
Conversation
- Added basic BarChart (the non-3D version) - Added initial multi-chart support. It's a bit of a hack right now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is going to need a lot more work to properly support, but I'd like to get your thoughts on the feasibility of moving forward with something along these lines. I have need of such support for a project, so will be working on this stuff for awhile.
Unfortunately, I think that over the long-term the concept of a "chart" and "plot" will need to be separated - right now they're somewhat grouped together but I feel that's going to cause more issues than not in the long term. Especially due to the mega meta-hack I had to do in https://github.com/pnomolos/axlsx/blob/fc994dbd4519d7263d221a6021c397973216bfe5/lib/axlsx/drawing/multi_chart.rb#L45-L62