Make comments work in office for mac 2015#382
Open
lexxor wants to merge 3 commits intorandym:masterfrom
Open
Conversation
Owner
|
Thanks lexxor. Couple of quick questions: Where did the changes in the xsd come from? We should be using the xsd from the documentation, so maybe there is an update out there we dont know about? Can I trouble you to add specs proving that the xml:space attribute is added? |
Author
|
Unfortunately, I didn't find any updates related to xml:space attribute. And I was forced to modify xsd myself to make tests green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
Office for Mac 2015 don't show comments without 'xml:space' attribute.
Here is comments.xml extracted from xlsx file, created with Office:
I can't test another office versions, but xlsx files exported from google docs also contains this attribute.