WIP: Accessibility improvements#373
Open
ruihbanki wants to merge 2 commits intoreact-component:masterfrom
Open
WIP: Accessibility improvements#373ruihbanki wants to merge 2 commits intoreact-component:masterfrom
ruihbanki wants to merge 2 commits intoreact-component:masterfrom
Conversation
To improve accessibility the active item is focused. Making the screen reader anounce the item.
|
Any idea when this PR will be merged/released? |
Member
|
Please help to check rc-menu@9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea of this pull request is to focus on the active item making the screen reader announce its content.
I would like to know if you approve of this approach for me to end this implementation by adding tests and looking for extreme cases.