Fix prepareLabels and unstable entity type order in SparqlDataProvider#114
Merged
Fix prepareLabels and unstable entity type order in SparqlDataProvider#114
prepareLabels and unstable entity type order in SparqlDataProvider#114Conversation
AlexeyMz
force-pushed
the
sparql-fix-attatch-labels
branch
from
4105be5 to
f35bbc0
Compare
…ider`: * Fix `prepareLabels` option for `SparqlDataProvider` to be applied for `knownElementTypes()`, `knownLinkTypes()`, `elementTypes()`, `linkTypes()`, `propertyTypes()` and `elements`. * Always sort entity types returned from `SparqlDataProvider.elements()`. * Add tests for basic `SparqlDataProvider` functionality and label/image options. * Add `@comunica/query-sparql-rdfjs-lite` to `devDependencies` (for tests): - Enable `skipLibCheck` to avoid type errors in `node_modules/rdf-parse/node_modules/lru-cache/dist/esm/index.d.ts`.
AlexeyMz
force-pushed
the
sparql-fix-attatch-labels
branch
from
f35bbc0 to
67eef60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prepareLabelsoption forSparqlDataProviderto be applied forknownElementTypes(),knownLinkTypes(),elementTypes(),linkTypes(),propertyTypes()andelements.SparqlDataProvider.elements().SparqlDataProviderfunctionality and label/image options.@comunica/query-sparql-rdfjs-litetodevDependencies(for tests):skipLibCheckto avoid type errors innode_modules/rdf-parse/node_modules/lru-cache/dist/esm/index.d.ts.