Conversation
JasoonS
left a comment
JasoonS
left a comment
There was a problem hiding this comment.
Looks clean to me (although I have zero authority here...)
|
@mattdamon108 @cristianoc What about this PR? The previously existing tests were removed in #49. Are we interested in re-adding tests? |
Not sure. Do they add value to justify the maintenance? E.g w.r.t. snapshot test where one just looks at the generated code? Could go either way. No opinion. |
|
I have no opinion. Actually, not sure what we should test for the binding module. |
Checking in che compiled output seems by far the easiest thing. And tells everything there is to know. |
| strategy: | ||
| matrix: | ||
| node-version: [10.x, 12.x] | ||
| node-version: [14.x] |
There was a problem hiding this comment.
We should probably add 16 since it's the current LTS release.
6 participants
→ Removes Jest
→ Updates peerDependencies
Test files render
Setup
Assertions setup
Tests
Test output render