Conversation
| pre_npm_install: | | ||
| cp -a "${ORCHESTRA_ROOT}/share/revng/pipeline/pipeline-description-schema.yml" . |
There was a problem hiding this comment.
Add a step in the installation of
revng-uiwhich installs the
pipeline-description-schema.ymlfile.
Can you give me some context on this?
There was a problem hiding this comment.
Basically revng installs the schema which describes the data exposed through the GET /pipeline endpoint, on the revng-ui side I use json-schema-to-typescript to get a typescript type file (.d.ts) which makes navigating the output much easier (and can report breakage if we ever change the /pipeline output and forget to update revng-ui)
There was a problem hiding this comment.
The commit message speaks about "installing pipeline-description-schema.yml".
AFAIU you're just copying to the build directory here, not installing anything.
Wouldn't it be more appropriate to let the revng-ui build system know where revng is installed instead of this out-of-band thing?
There was a problem hiding this comment.
Eh, there isn't a "revng-ui build system", we re-use vscode_extension which basically does npm install && npm run package so IMHO there isn't much to do about it
MkDocs version 2.0 has been announced and it includes breaking changes for themes. Prevent 2.0 from being used to avoid any surprises in the future.
Add `starlette` as an explicit dependency, until now it was installed as part of `ariadne` but that dependency will be dropped soon.
Add a step in the installation of `revng-ui` which installs the `pipeline-description-schema.yml` file.
mrjackv
force-pushed
the
feature/pypeline-integrate-ui
branch
from
bac7a52 to
96de165
Compare
`ariadne` version 0.29.0 introduces breaking changes. Since this dependency will be deprecated soon, pin it to the latest version without the breaking change.
2 participants
No description provided.