draft: Data explorer UI for OLAP #8737
Draft
+3,875
−2,318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace hardcoded connector lists with schema-based metadata: - Multi-step detection now derives from x-category='objectStore' - Explorer mode detection derives from x-category='sqlStore'|'warehouse' - Form heights now driven by x-form-height schema property Remove MULTI_STEP_CONNECTORS, TALL_FORM_CONNECTORS, and associated constants from constants.ts. Add getFormHeight(), isMultiStepConnector(), and isExplorerConnector() helpers to connector-schemas.ts that read from schema metadata instead.
Move form creation out of AddDataFormManager into a dedicated createConnectorForm() factory function in FormValidation.ts. The manager now accepts form stores as parameters instead of creating them, making it a pure orchestration layer that handles step flow, submission routing, and validation coordination. This separation allows form creation to be reused and tested independently of the orchestration logic.
Remove properties and filteredParamsProperties from AddDataFormManager as they were computed but never used - computeYamlPreview retrieves schema fields directly when needed. This completes the simplification of AddDataFormManager to a thin orchestration layer that derives all behavior from JSON schemas.
When S3 sources are rewritten to DuckDB, the model YAML was incorrectly using the original connector instance name (s3) instead of duckdb. This caused the backend to expect a 'path' property but receive 'sql', resulting in "missing property \`path\`" errors. Now when a connector is rewritten to DuckDB, the YAML connector field uses duckdb, while credential access is maintained via create_secrets_from_connectors.
When S3 sources are rewritten to DuckDB, the model YAML was incorrectly using the original connector instance name (s3) instead of duckdb. This caused the backend to expect a 'path' property but receive 'sql', resulting in "missing property \`path\`" errors. Now when a connector is rewritten to DuckDB, the YAML connector field uses duckdb, while credential access is maintained via create_secrets_from_connectors.
Enable users to choose between rill-managed infrastructure and self-hosted ClickHouse Cloud connections, mirroring the same pattern used in the standard ClickHouse connector.
- Add openExplorerForConnector function to open Data Explorer directly - Add + button to ConnectorEntry for OLAP connectors to open Data Explorer - Integrate explorer step into AddDataForm after PR #8632 merge - Show AddDataExplorerStep when in explorer mode, hide footer/sidebar Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Remove duplicate header from AddDataExplorerStep (modal title handles it) - Pass schemaName in openExplorerForConnector so modal title renders correctly Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Create ConnectorExplorerButton.svelte for OLAP connectors - Add button to WorkspaceHeader for connector pages - Remove button from ConnectorEntry sidebar Co-Authored-By: Claude Opus 4.5 <[email protected]>
made small tweaks to UI to simplify UX.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
building off Cyrus' work on Data Explorer with a few small tweaks.
Once #8736 is in, we'll have the italized connector_name in the UI.
Checklist: