This repository was archived by the owner on Apr 4, 2024. It is now read-only.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the hotkey save state didn't create a snapshot for the save states so I tweaked the State_write to save a snapshot.
I'm not 100% satisfied with this - the hotkeys vs menu save states seem to be treated quite differently in ways I don't totally understand (I'm pretty sure the hotkeys don't save disk information (txt_path) along with other differences). Due to this, I did not remove the menu item save state's txt_path and snapshot stuff. As a result, the snapshot is being created twice in this situation.
I'm also not crazy about the fact that hotkeys seem to always save to either save state 0 or to whatever was last interacted with in the menu. This behavior seems a little weird but I'm not sure what to do about it.