avoid stale parameter events in content filter tests.#3085
Open
fujitatomoya wants to merge 1 commit intorollingfrom
Open
avoid stale parameter events in content filter tests.#3085fujitatomoya wants to merge 1 commit intorollingfrom
fujitatomoya wants to merge 1 commit intorollingfrom
Conversation
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
commented
Feb 27, 2026
Collaborator
Author
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
@Barry-Xu-2018 can you review this? i confirmed that this passes for both connextdds and fastdds.
Collaborator
Author
|
Pulls: #3085
|
| // To make this test deterministic, we use an event-level callback that only | ||
| // inspects changed_parameters for the assertion flags, rather than relying on | ||
| // parameter-level callbacks which cannot distinguish new vs changed. | ||
| auto event_handler = param_handler->add_parameter_event_callback(cb_changed_event); |
Collaborator
There was a problem hiding this comment.
The original purpose of the test was to check the impact of content filter for add_parameter_callback().
Therefore, it is recommended to use add_parameter_callback() for test.
What do you think about making this change?
const std::string remote_node1_param_name = "param_node1";
const std::string remote_node2_param_name = "param_node2";
remote_node1->declare_parameter(remote_node1_param_name, 10);
remote_node2->declare_parameter(remote_node2_param_name, "Default");
+ // Add an explanation similar to the one in above test.
+ param_handler.reset();
+ param_handler = std::make_shared<TestParameterEventHandler>(node);
+
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3065
Is this user-facing behavior change?
No
Did you use Generative AI?
No
Additional Information