Create the tmp/sessions dir if it doesn't exist#46
Open
adammck wants to merge 1 commit intorubycas:masterfrom
Open
Create the tmp/sessions dir if it doesn't exist#46adammck wants to merge 1 commit intorubycas:masterfrom
adammck wants to merge 1 commit intorubycas:masterfrom
Conversation
Member
|
I would request one tweak to this. Instead of running the whole example set for the case when the session directory doesn't exist, can you just assert that it gets created? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given that the directory is temporary, it seems reasonable to silently create it if it doesn't already exist. This just tripped me up because our deployment script wasn't creating the directory.