docs/tests: fix rustdoc links and appease clippy strict lints#1576
docs/tests: fix rustdoc links and appease clippy strict lints#1576nilgoyette merged 5 commits intorust-ndarray:masterfrom
Conversation
|
@RPG-Alex same question as before, is this just another round of |
If you want to add it to the CI then be aware that the strictest setting is still sending errors: error: this range is empty so it will yield no values
--> benches/bench1.rs:746:35
|
746 | let a = a.slice_mut(s![1..-1, 1..-1]);
| ^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#reversed_empty_ranges
help: consider using the following if you are attempting to iterate over this range in reverse
|
746 - let a = a.slice_mut(s![1..-1, 1..-1]);
746 + let a = a.slice_mut(s![1..-1, (-1..1).rev()]);This one is odd and I was considering opening an isuse about these tests as |
Unless I am mistaken, |
|
@nilgoyette my comment was regarding if you added a stricter clippy check to the CI this is the error it would return. I didn't open an issue and assumed that was intended to be written that way. Is this PR acceptable currently? |
|
Yes, this PR is acceptable. Sorry for the wait. @akern40 may want a stricter setting (?) but it can be done in another PR if need be. Thank you for your contribution. |
Tighten linting; fix rustdoc warnings across feature gates
I continued using stricter linting and found several odd cases in tests and
examples, along with rustdoc warnings triggered by feature-gated items.
This commit cleans up those warnings by:
linking to non-exported items
All tests are still passing.
Clippy still warns about the use of
1..-1as an empty range; this appearsintentional in ndarray slicing semantics, so I’ve left it unchanged for now.
Please review the rustdoc changes that rely on feature-gated documentation.