Open
Conversation
bash isn't in /bin on all systems, if it even exists. (FreeBSD, for one, ships with sh, and bash would install to /usr/local/bin) Changed to #!/bin/sh because it doesn't look like you're doing anything bash-specific anyway, that isn't in any other POSIX-compliant sh-derivative
git mangled my change for some reason and only pushed the delete. Shebang fix: redux!
Author
|
Seems a a small change, but I'd like to get Phenny into the FreeBSD ports tree, if that's cool with you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doesn't look like you're doing anything bash specific, and bash doesn't reside in /bin on the BSDs, so for portability's sake, bumped it down to /bin/sh so it'll be happy with any reasonably compliant POSIX sh derivative.