[WIP] Add update policy page functionality for Crossmark by Copilot · Pull Request #1373 · scieloorg/core

Copilot · 2026-03-05T16:47:54Z

Thanks for assigning this issue to me. I'm starting to work on it and will keep this PR's description up to date as I form a plan and make progress.

Original prompt

This section details on the original issue you should resolve

<issue_title>gestão da página de política de atualização (crossmark)</issue_title>
<issue_description>### 1. Política de atualização (update policy page)

(core) criar funcionalidade para completar um campo com o DOI da página de política do crossmark

(core) criar funcionalidade para completar um campo que o DOI da página do crossmark está ativa

(core) criar funcionalidade para completar um campo ou página do periódico para as políticas de correção, retratação, withdrawal e demais tipos de atualização do SciELO - gerar a página de política

(core) Registrar no Crossref o DOI para a página de política de atualização (crossmark)
</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes Criar a funcionalidade para gerir os dados da página de política de atualização (crossmark) #1372

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…l, choices, and migration Co-authored-by: robertatakenaka <505143+robertatakenaka@users.noreply.github.com>

robertatakenaka · 2026-03-06T14:41:39Z

journal/models.py

+    crossmark_policy_doi = models.CharField(
+        _("Crossmark Policy DOI"),
+        max_length=100,
+        blank=True,
+        null=True,
+        help_text=_(
+            "DOI of the crossmark update policy page for this journal"
+        ),
+    )


@copilot este campo

crossmark_policy_doi = models.CharField( _("Crossmark Policy DOI"), max_length=100, blank=True, null=True, help_text=_( "DOI of the crossmark update policy page for this journal" ), )

deveria ser movido para dentro de UpdatePolicy

robertatakenaka · 2026-03-06T14:43:01Z

journal/models.py

+    crossmark_doi_is_active = models.BooleanField(
+        verbose_name=_("Crossmark DOI is active"),
+        default=False,
+        help_text=_(
+            "Indicates whether the crossmark policy DOI page is active"
+        ),
+    )


@copilot mover este campo crossmark_doi_is_active para UpdatePolicy e aqui no lugar de campo criar property que retorna o resultado de UpdatePolicy.objects.filter(crossmark_doi_is_active=True).exists()

robertatakenaka · 2026-03-06T14:44:04Z

journal/models.py

+    and other update types registered with Crossmark.
+    """
+
+    policy_type = models.CharField(


@copilot eliminar policy_type e códigos relacionados

robertatakenaka · 2026-03-06T14:51:34Z

journal/models.py

    )


+class UpdatePolicy(Orderable, RichTextWithLanguage, CommonControlField):


@copilot prefiro adotar o nome CrossmarkPolicy no lugar de UpdatePolicy

robertatakenaka · 2026-03-06T17:11:03Z

@copilot resolva as questões

…lização (crossmark) (#1381) * chore(journal): remove migração 0057 gerada para crossmark update policy Remove a migration 0057 que adicionava os campos crossmark_policy_doi e crossmark_doi_is_active diretamente no modelo Journal e criava o modelo UpdatePolicy. Esses campos e modelo serão substituídos pela nova abordagem com CrossmarkPolicy. * feat(journal): adiciona migração para criação do modelo CrossmarkPolicy Cria o modelo CrossmarkPolicy com os campos doi, is_active, url, language, journal (ParentalKey com CASCADE), creator e updated_by. Substitui a abordagem anterior que armazenava crossmark_policy_doi e crossmark_doi_is_active diretamente no modelo Journal. * refactor(journal): substitui UpdatePolicy por CrossmarkPolicy e converte campo para property - Renomeia modelo UpdatePolicy para CrossmarkPolicy com campos doi, is_active e url - Remove campos crossmark_policy_doi e crossmark_doi_is_active do modelo Journal - Adiciona property crossmark_doi_is_active em Journal que retorna True se houver alguma CrossmarkPolicy ativa (is_active=True) - Altera related_name de update_policy para crossmark_policy - Altera on_delete de SET_NULL para CASCADE e torna journal e url obrigatórios * refactor(journal): atualiza proxys para usar crossmark_policy no lugar de update_policy - Substitui InlinePanel update_policy por crossmark_policy em JournalProxyEditor e JournalProxyPanelPolicy - Remove FieldPanels crossmark_policy_doi e crossmark_doi_is_active, agora gerenciados via CrossmarkPolicy inline

Copilot

Pull request overview

Adds initial data model and admin UI hooks to manage a journal’s Crossmark “Update Policy” information (DOI/active flag/URL and rich text), as a foundation for later Crossref/Crossmark registration work.

Changes:

Introduces CrossmarkPolicy model (with DOI, active flag, URL, language, rich text) and a DB migration.
Exposes crossmark_policy as an InlinePanel in journal proxy editor/policy admin panels.
Adds Journal.crossmark_doi_is_active helper and a new UPDATE_POLICY_TYPE choices list.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
`journal/proxys.py`	Adds `crossmark_policy` InlinePanel to editor and policy panel configurations.
`journal/models.py`	Adds `CrossmarkPolicy` model and `crossmark_doi_is_active` property on `Journal`.
`journal/migrations/0057_crossmarkpolicy.py`	Creates the `CrossmarkPolicy` table and relations.
`journal/choices.py`	Adds `UPDATE_POLICY_TYPE` choice list (currently unused).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-06T20:07:12Z

journal/models.py

+class CrossmarkPolicy(Orderable, RichTextWithLanguage, CommonControlField):
+    """
+    Update Policy (Crossmark) - policies for correction, retraction, withdrawal
+    and other update types registered with Crossmark.
+    """
+    doi = models.CharField(
+        max_length=255,
+        null=True,
+        blank=True,
+    )
+    is_active = models.BooleanField(
+        verbose_name=_("Crossmark DOI is active"),
+        default=False,
+        help_text=_(
+            "Indicates whether the crossmark policy DOI page is active"
+        ),
+    )
+    url = models.URLField(
+        _("Policy URL"),
+        null=False,
+        blank=False,
+        help_text=_(
+            "URL of the policy page describing how the journal handles this type of update"
+        ),
+    )


CrossmarkPolicy is described as covering multiple update types (correction/retraction/withdrawal/etc.), and this PR also introduces UPDATE_POLICY_TYPE choices, but the model has no field to capture which update type a given policy entry represents. Without a type field, multiple CrossmarkPolicy rows for a journal will be indistinguishable beyond free-text. Consider adding a policy_type/update_type field (with choices=UPDATE_POLICY_TYPE) or removing the unused choices if the intent is a single generic policy page.

Copilot · 2026-03-06T20:07:13Z

journal/models.py


+    @property
+    def crossmark_doi_is_active(self):
+        return self.crossmark_policy.filter(is_active=True).exists()


crossmark_doi_is_active currently only checks for any related CrossmarkPolicy with is_active=True, but it doesn’t verify that a DOI value is actually present. As a result, the property can return True even when the active record has doi empty/null, which seems inconsistent with the property name and could lead to incorrect downstream behavior. Consider also filtering for non-empty DOI (or rename the property to reflect that it’s only the flag).

Suggested change

return self.crossmark_policy.filter(is_active=True).exists()

return (

self.crossmark_policy.filter(is_active=True)

.exclude(doi__isnull=True)

.exclude(doi__exact="")

.exists()

)

Copilot · 2026-03-06T20:07:13Z

journal/models.py

+        ),
+    )
+    journal = ParentalKey(
+        Journal, on_delete=models.CASCADE, related_name="crossmark_policy", null=False


All other Orderable, RichTextWithLanguage, CommonControlField journal-policy models in this section use ParentalKey(Journal, on_delete=models.SET_NULL, null=True, ...), but CrossmarkPolicy is the only one using on_delete=models.CASCADE and null=False. This inconsistency can make lifecycle/cleanup behavior differ from the rest of the journal policy inlines. Consider aligning journal with the existing pattern (and updating the migration accordingly) unless there’s a strong reason for CrossmarkPolicy to behave differently.

Suggested change

Journal, on_delete=models.CASCADE, related_name="crossmark_policy", null=False

Journal, on_delete=models.SET_NULL, related_name="crossmark_policy", null=True

Initial plan

635816f

Copilot AI assigned Copilot and robertatakenaka Mar 5, 2026

Add crossmark update policy management: new fields, UpdatePolicy mode…

166ab34

…l, choices, and migration Co-authored-by: robertatakenaka <505143+robertatakenaka@users.noreply.github.com>

robertatakenaka reviewed Mar 6, 2026

View reviewed changes

robertatakenaka marked this pull request as ready for review March 6, 2026 20:02

Copilot AI review requested due to automatic review settings March 6, 2026 20:02

Copilot started reviewing on behalf of robertatakenaka March 6, 2026 20:03 View session

Copilot AI reviewed Mar 6, 2026

View reviewed changes

robertatakenaka merged commit 17f68a8 into main Mar 6, 2026
7 of 9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Add update policy page functionality for Crossmark#1373

[WIP] Add update policy page functionality for Crossmark#1373
robertatakenaka merged 3 commits intomainfrom
copilot/update-policy-page-crossmark

Copilot AI commented Mar 5, 2026

Uh oh!

robertatakenaka Mar 6, 2026

Uh oh!

robertatakenaka Mar 6, 2026

Uh oh!

robertatakenaka Mar 6, 2026

Uh oh!

robertatakenaka Mar 6, 2026

Uh oh!

robertatakenaka commented Mar 6, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 6, 2026

Uh oh!

Copilot AI Mar 6, 2026

Uh oh!

Copilot AI Mar 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		)


		class UpdatePolicy(Orderable, RichTextWithLanguage, CommonControlField):

	Journal, on_delete=models.CASCADE, related_name="crossmark_policy", null=False
	Journal, on_delete=models.SET_NULL, related_name="crossmark_policy", null=True

Conversation

Copilot AI commented Mar 5, 2026

Comments on the Issue (you are @copilot in this section)

Uh oh!

robertatakenaka Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

robertatakenaka Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

robertatakenaka Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

robertatakenaka Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

robertatakenaka commented Mar 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants