Skip to content

Conversation

@oittaa
Copy link
Contributor

@oittaa oittaa commented Jan 27, 2026

The URL regex was previously broken but the test passed because "Secret" matched from the key and the Zxcvbn entropy was high enough. If the default truncate length would have been increased from 16 to something higher the test wouldn't have passed since Zxcvbn would have detected the repeated pattern.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.47%. Comparing base (1216c9b) to head (aaf1e72).
⚠️ Report is 177 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1485      +/-   ##
==========================================
+ Coverage   68.49%   69.47%   +0.97%     
==========================================
  Files          75       85      +10     
  Lines        4384     6732    +2348     
==========================================
+ Hits         3003     4677    +1674     
- Misses       1233     1827     +594     
- Partials      148      228      +80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@ravisastryk ravisastryk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ccojocar ccojocar merged commit a631af8 into securego:master Jan 28, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants