Skip to content

build: override bundled libsemigroups install paths#1074

Open
jengelh wants to merge 2 commits intosemigroups:stable-5.6from
jengelh:master
Open

build: override bundled libsemigroups install paths#1074
jengelh wants to merge 2 commits intosemigroups:stable-5.6from
jengelh:master

Conversation

@jengelh
Copy link

@jengelh jengelh commented Jul 21, 2025

Fixes: #1073

@james-d-mitchell
Copy link
Collaborator

Thanks for the PR @jengelh, the "with-external-libsemigroups" is expected to fail at the moment, but not the Cygwin job, any chance you could adapt the changes in this PR so that the Cygwin job also passes? Thanks!

@james-d-mitchell james-d-mitchell added the build-system A label for issues or PRs related to the build system label Jul 25, 2025
@jengelh
Copy link
Author

jengelh commented Jul 25, 2025

cygwin x64

Now running tests from tst/teststandard.g
Error, Variable: 'SemigroupsTestInstall' must have a value
Error: Process completed with exit code 1.

That does not look like dll related things (or if, it's not very indicative).

@james-d-mitchell
Copy link
Collaborator

It states just above this that the kernel module isn't compiled, I guess it is unable to find the DLL, which would be related to your changes I think

@james-d-mitchell
Copy link
Collaborator

james-d-mitchell commented Mar 24, 2026

Just rebased onto main, let's see if the ci passes.

@james-d-mitchell
Copy link
Collaborator

@jengelh the cygwin job still fails, I'm afraid. @Joseph-Edwards any chance you can take a look at this in the meeting tomorrow?

@Joseph-Edwards
Copy link
Collaborator

@Joseph-Edwards any chance you can take a look at this in the meeting tomorrow?

Will do

@james-d-mitchell james-d-mitchell changed the base branch from main to stable-5.6 March 26, 2026 17:26
@james-d-mitchell
Copy link
Collaborator

james-d-mitchell commented Mar 26, 2026

@jengelh the changes in my commit here fix the ci, can you please confirm whether or not the changes we've reverted were not essential to your pr? I.e. does the pr as given resolve issue #1073 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build-system A label for issues or PRs related to the build system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure due to faulty attempt to install libsemigroups

3 participants