feat(scripts): SSH agent auth support for deployment scripts#5
Open
theredspoon wants to merge 7 commits intosimple10:mainfrom
Open
feat(scripts): SSH agent auth support for deployment scripts#5theredspoon wants to merge 7 commits intosimple10:mainfrom
theredspoon wants to merge 7 commits intosimple10:mainfrom
Conversation
IdentitiesOnly=yes restricts auth to explicitly listed identity files. When SSH_KEY is unset, this causes auth failures because no IdentityFile is specified. Remove it so the agent can offer all loaded keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SSH_IDENTITY_AGENTsupport to all deployment scripts, allowingauthentication via an SSH agent socket (e.g., Bitwarden, 1Password,
ssh-agent) without requiring a key file path in
.envSSH_KEYoptional — if unset, scripts fall back to the user'snormal SSH config and agent behavior
IdentitiesOnly=yesbeing set alongsideIdentityAgent, whichcaused auth failures when no
IdentityFilewas configuredChanges
scripts/lib/ssh.sh: refactored from a single SSH_CMD string toSSH_ARGS/SCP_ARGS arrays; conditional
-i/IdentityAgentflags;SSH_RSYNC_CMD derived from the same args for rsync compatibility
scripts/ssh-agent.sh: helper to set/detect SSH_IDENTITY_AGENT.env.example: documents SSH_IDENTITY_AGENT optionTested