[Mage] unbelievably minor fix for Brainstorm + Clearcasting#10905
Merged
Dorovon merged 4 commits intosimulationcraft:midnightfrom Feb 22, 2026
Merged
[Mage] unbelievably minor fix for Brainstorm + Clearcasting#10905Dorovon merged 4 commits intosimulationcraft:midnightfrom
Dorovon merged 4 commits intosimulationcraft:midnightfrom
Conversation
Armadk
pushed a commit
to ebonhold/simc
that referenced
this pull request
Feb 23, 2026
…oncraft#10905) * base, need to check how totm behaves w/ aegwynns tech * done? * added some old comment * condense comments + make delay local
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trigger_clearcasting() doesn't need delay as a parameter anymore due to them scrapping it altogether -- a delay is only ever relevant when arcane soul double procs cc. kept it there just for the future. lemme know.