feat: Add Indirect buffer usage and support .dispatchWorkgroupsIndirect API#2105
Open
feat: Add Indirect buffer usage and support .dispatchWorkgroupsIndirect API#2105
Indirect buffer usage and support .dispatchWorkgroupsIndirect API#2105Conversation
📊 Bundle Size Comparison
👀 Notable resultsStatic test results:
Dynamic test results:
📋 All resultsClick to reveal the results table (335 entries).
If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu. |
|
pkg.pr.new packages benchmark commit |
reczkok
commented
Jan 26, 2026
Comment on lines
+190
to
+216
| const meta = new Map<string, StructFieldMeta>(); | ||
|
|
||
| let runStart = 0; | ||
| for (let i = 0; i < propNames.length; i++) { | ||
| const name = propNames[i]; | ||
| if (!name) { | ||
| continue; | ||
| } | ||
| const info = offsets[name] as PropOffsetInfo; | ||
| const padding = info.padding ?? 0; | ||
|
|
||
| const isRunEnd = i === propNames.length - 1 || padding > 0; | ||
| if (!isRunEnd) { | ||
| continue; | ||
| } | ||
|
|
||
| const runEnd = info.offset + info.size; | ||
| for (let j = runStart; j <= i; j++) { | ||
| const runName = propNames[j]; | ||
| if (!runName) { | ||
| continue; | ||
| } | ||
| const runInfo = offsets[runName] as PropOffsetInfo; | ||
| meta.set(runName, { offset: runInfo.offset, runEnd }); | ||
| } | ||
| runStart = i + 1; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I'm not quite sure we need this. We could just walk from accessed prop until we run out of requested memory or hit padding. This would make the API less flexible though (and worst case actually calculate more). This solution seemed nice for detecting contiguous memory and I thought maybe we could use it in the future (compiled partial write). I can simplify it if it's deemed too complex/expensive.
reczkok
requested review from
aleksanderkatan,
cieplypolar,
iwoplaza and
lursz
iwoplaza
reviewed
Jan 28, 2026
cieplypolar
reviewed
Feb 12, 2026
Collaborator
There was a problem hiding this comment.
Great use of accessors. However, the calculation of the longest contiguous block starting at given offset isn't correct. See #2159
| let runStart = 0; | ||
| for (let i = 0; i < propNames.length; i++) { | ||
| const name = propNames[i]; | ||
| if (!name) { |
Collaborator
There was a problem hiding this comment.
Can user define a struct with the empty string as a key?
Contributor
There was a problem hiding this comment.
isValidProp does not yet filter this, but it should
Comment on lines
+190
to
+216
| const meta = new Map<string, StructFieldMeta>(); | ||
|
|
||
| let runStart = 0; | ||
| for (let i = 0; i < propNames.length; i++) { | ||
| const name = propNames[i]; | ||
| if (!name) { | ||
| continue; | ||
| } | ||
| const info = offsets[name] as PropOffsetInfo; | ||
| const padding = info.padding ?? 0; | ||
|
|
||
| const isRunEnd = i === propNames.length - 1 || padding > 0; | ||
| if (!isRunEnd) { | ||
| continue; | ||
| } | ||
|
|
||
| const runEnd = info.offset + info.size; | ||
| for (let j = runStart; j <= i; j++) { | ||
| const runName = propNames[j]; | ||
| if (!runName) { | ||
| continue; | ||
| } | ||
| const runInfo = offsets[runName] as PropOffsetInfo; | ||
| meta.set(runName, { offset: runInfo.offset, runEnd }); | ||
| } | ||
| runStart = i + 1; | ||
| } |
| ); | ||
|
|
||
| expect(info.offset).toBe(128); | ||
| expect(info.contiguous).toBe(16); |
Collaborator
There was a problem hiding this comment.
Suggested change
| expect(info.contiguous).toBe(16); | |
| expect(info.contiguous).toBe(28); |
Look at #2159
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update: I guess TODO solved - we now expose the API to the user
TODO: Solve the caching problem (should we cache the accessor callbacks? Proxy creation per frame will have significant overhead)