fix(deps): update ag-grid monorepo to v35 (major)#3488
Open
renovate[bot] wants to merge 1 commit intomasterfrom
Open
fix(deps): update ag-grid monorepo to v35 (major)#3488renovate[bot] wants to merge 1 commit intomasterfrom
renovate[bot] wants to merge 1 commit intomasterfrom
Conversation
Pull Request Test Coverage Report for Build 22508059240Details
💛 - Coveralls |
24e3804 to
7660232
Compare
106f672 to
79d8de5
Compare
f01b4dd to
3cd3d13
Compare
6c65b89 to
ba3fe4e
Compare
3c9033a to
11704b7
Compare
323cd06 to
c6c0e8c
Compare
c6c0e8c to
72ae829
Compare
119d5a1 to
2273d15
Compare
Comment on lines
52
to
+55
| "ace-builds": "^1.42.1", | ||
| "acorn": "^8.9.0", | ||
| "ag-grid-community": "^34.1.1", | ||
| "ag-grid-react": "^34.1.1", | ||
| "ag-grid-community": "^35.0.0", | ||
| "ag-grid-react": "^35.0.0", |
There was a problem hiding this comment.
Bug: The upgrade to ag-grid v35 introduces automatic overlays that conflict with the code's use of deprecated manual overlay APIs like hideOverlay() and showNoRowsOverlay().
Severity: MEDIUM
Suggested Fix
Update the code to use the modern ag-grid v35 API. Either remove the deprecated manual calls to hideOverlay() and showNoRowsOverlay() and rely on the new automatic overlays, or explicitly suppress the new behavior using the suppressOverlays grid option (e.g., suppressOverlays=['noMatchingRows']) if manual control is still desired.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: package.json#L52-L55
Potential issue: The upgrade to `ag-grid` v35 introduces a new automatic overlay system
for tables. However, components like `GradingSubmissionsTable.tsx` and
`OverallLeaderboard.tsx` continue to use deprecated manual overlay control APIs
(`hideOverlay()`, `showNoRowsOverlay()`), which were deprecated in v32. This conflict
between the new automatic behavior and the old manual calls can lead to duplicate or
flickering overlays. For example, when a floating filter in `GradingSubmissionsTable`
yields no results, both the new automatic overlay and the manually triggered one might
appear, creating a confusing user experience.
47cdff9 to
6dba7b4
Compare
6dba7b4 to
cb4ccc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^34.1.1→^35.0.0^34.1.1→^35.0.0Release Notes
ag-grid/ag-grid (ag-grid-community)
v35.1.0Compare Source
v35.0.1Compare Source
v35.0.0Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.